| From: | "Shulgin, Oleksandr" <oleksandr(dot)shulgin(at)zalando(dot)de> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Merlin Moncure <mmoncure(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Ryan Pedela <rpedela(at)datalanche(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Sehrope Sarkuni <sehrope(at)jackdb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add jsonb_compact(...) for whitespace-free jsonb to text |
| Date: | 2016-05-02 08:56:08 |
| Message-ID: | CACACo5Tge6=Ta3LYz_QDPapnSw0vThECGP6H_8uynJE=d8bTMg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, May 1, 2016 at 3:22 AM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
> On 04/29/2016 06:11 PM, Merlin Moncure wrote:
>
> This is a simple matter of removing spaces in the occasional C string
>> literal in the serialization routines and adding a json_pretty
>> function.
>>
>
> I spent a few hours on this. See <
> https://bitbucket.org/adunstan/pgdevel/commits/branch/jsonformat> for WIP
> - there are three commits. No regression tests yet for the two new
> functions (json_squash and json_pretty), Otherwise fairly complete.
> Removing whitespace generation was pretty simple for both json and jsonb.
>
Looks good, thank you!
It would make sense IMO to rename FormatState's `indent' field as `pretty':
it's being used to add whitespace between the punctuation, not only at
start of a line. I'd also move the "if (indent)" check out of
add_indent(): just don't call it if no indent is needed.
I'll try to play with the patch to produce some regression tests for the
new functions.
--
Alex
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2016-05-02 10:51:37 | what does function EmitWarningsOnPlaceholders? |
| Previous Message | Daniel Gustafsson | 2016-05-02 08:40:24 | Subtle bug in autoconf flex version test |