Re: Deal with <>s in message IDs

On Fri, Oct 31, 2014 at 11:26 PM, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com> wrote:
> On 10/31/14, 6:11 AM, Magnus Hagander wrote:
>>
>> On Thu, Oct 30, 2014 at 7:16 PM, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>
>> wrote:
>>>
>>> On 10/30/14, 7:19 AM, Magnus Hagander wrote:
>>>>
>>>>
>>>> > I'm not really sure this really belongs in the archives app. We
>>>> could
>>>> > just have the commitfest app remove them on input.
>>>> >
>>>>
>>>> Oh, now I get it. Yeah, based on that it does sound like the wrong place
>>>> to fix it. Though if it's easy enough it might be worth doing for
>>>> convenience. I'll see if there's some place to stick a regexp that can
>>>> do it
>>>> safely.
>>>
>>>
>>>
>>> Yes, my original question was if we could basically do the same thing
>>> we're
>>> doing now to handle /'s. See
>>>
>>> http://git.postgresql.org/gitweb/?p=pgarchives.git;a=blob;f=django/archives/urls.py;h=d524999dcca8a123b05c294c218d7d93977f4060;hb=HEAD#l28
>>> (line 28) and
>>>
>>> http://git.postgresql.org/gitweb/?p=pgarchives.git;a=blob;f=django/archives/mailarchives/views.py;h=f6c401a6458ee16050fcd5837a33e848d3cb7644;hb=HEAD#l557
>>> (line 557).
>>
>>
>> Thats actually something different - that deals with the training
>> slash sometimes added by django, and is done for cache limitation.
>> Slashes *in* messageids is independent of that. That's why I
>> misunderstood you :)
>>
>> That doesn't mean it's not possible to work around it of course. We
>> have a grand total of 6 messages in our archives that have < or > in
>> the messageid, but as long as we only eat one of them, and only at
>> beginning or end, it should be safe.
>
>
> Were you going to take a stab at it or do you want me to? I don't know that
> I'd be able to test whatever I come up with...

I've put it on my TODO list yeah. But if you want to take a stab at it
go ahead - though I'm not sure it's worth too much without setting up
an env to test it, since that's likely the part that takes the most
time :) But if you want to do that.. :)

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/