| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: "unexpected EOF" messages |
| Date: | 2012-05-07 17:20:46 |
| Message-ID: | CABUevEzHcJnOGjH1i7BX7Omf-sXhLOOmtF2-93Co591D2PRjYQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, May 7, 2012 at 7:18 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Mon, May 7, 2012 at 12:39 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> Makes sense, will change and commit.
>
> Since the following hunk is repeated 3x, maybe it should be stuffed
> into a function that is then called in three places:
I considered it trivial enough not to do that for it. I can perhaps be
convinced otherwise, but I doubt it's worth it..
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2012-05-07 17:22:35 | Re: Uppercase tab completion keywords in psql? |
| Previous Message | Robert Haas | 2012-05-07 17:18:03 | Re: "unexpected EOF" messages |