Re: Patch to allow users to kill their own queries

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Greg Smith <greg(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch to allow users to kill their own queries
Date: 2012-01-13 13:46:15
Message-ID: CABUevExSb4C3cP+eLaaewufN8khDPdeF2ckj2hSiZBxkQ-f9Pg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 13, 2012 at 14:42, Greg Smith <greg(at)2ndquadrant(dot)com> wrote:
> On 01/03/2012 12:59 PM, Tom Lane wrote:
>>
>> Noah Misch<noah(at)leadboat(dot)com>  writes:
>>
>>>
>>> Regarding the other message, avoid composing a translated message from
>>> independently-translated parts.
>>>
>>
>> Yes.  I haven't looked at the patch, but I wonder whether it wouldn't be
>> better to dodge both of these problems by having the subroutine return a
>> success/failure result code, so that the actual ereport can be done at
>> an outer level where the full message (and hint) can be written
>> directly.
>>
>
>
> Between your and Noah's comments I understand the issue and likely direction
> to sort this out now.  Bounced forward to the next CommitFest and back on my
> plate again.  Guess I'll be learning new and exciting things about
> translation this week.

I should say that I have more or less finished this one off, since I
figured you were working on more important things. Just a final round
of cleanup and commit left, really, so you can take it off your plate
again if you want to :-)

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2012-01-13 14:03:49 Re: Disabled features on Hot Standby
Previous Message Greg Smith 2012-01-13 13:42:52 Re: Patch to allow users to kill their own queries