| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Marko Kreen <markokr(at)gmail(dot)com>, "Dr(dot) Andreas Kunert" <kunert(at)cms(dot)hu-berlin(dot)de>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Feature request: Logging SSL connections |
| Date: | 2014-01-19 12:27:38 |
| Message-ID: | CABUevEwXC+3YR8vvOgd9fpKpHaAXgBDhdhuR6tbp2+FeKyke2Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 17, 2014 at 4:53 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
> > Applied, thanks!
>
> Minor bikeshedding: the messages would read better, to my eye, as
>
> "user=%s database=%s SSL enabled (protocol=%s, cipher=%s)"
>
> Putting "enabled" where it is requires extra mental gymnastics on
> the part of the reader. And why the random change between "="
> in one part of the string and ": " in the new part? You could take
> that last point a bit further and make it
>
Makes sense.
"user=%s database=%s SSL=enabled (protocol=%s, cipher=%s)"
>
> but I'm not sure if that's an improvement.
>
I don't think it is, so I've applied the first suggestion.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2014-01-19 13:12:10 | Re: array_length(anyarray) |
| Previous Message | David Rowley | 2014-01-19 12:04:40 | Re: [PATCH] Negative Transition Aggregate Functions (WIP) |