| From: | Marti Raudsepp <marti(at)juffo(dot)org> |
|---|---|
| To: | Ali Akbar <the(dot)apaan(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Платон Малюгин <malugin(dot)p(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add generate_series(numeric, numeric) |
| Date: | 2014-10-06 15:51:06 |
| Message-ID: | CABRT9RDmAnUi1C6=szgBr9PG2XaXe81_Q5Vsg6f_JuCxCeJyDw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 6, 2014 at 6:12 PM, Ali Akbar <the(dot)apaan(at)gmail(dot)com> wrote:
> User apaan is me. When i added to the commitfest, the patch is listed there
> by me (apaan).
That's fine I think, it's just for tracking who made the changes in
the CommitFest app. What actually matters is what you write in the
"Author" field, which could contain all 3 names separated by commas.
> the one that tests values just before numeric overflow
Actually I don't know if that's too useful. I think you should add a
test case that causes an error to be thrown.
Also, I noticed that there are a few trailing spaces in the patch that
should be removed:
+generate_series_numeric(PG_FUNCTION_ARGS)
...
+ if (NUMERIC_IS_NAN(start_num) || NUMERIC_IS_NAN(finish_num))
...
+ if (PG_NARGS() == 3)
...
+ if (NUMERIC_IS_NAN(step_num))
Regards,
Marti
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marco Nenciarini | 2014-10-06 15:51:11 | Re: [RFC] Incremental backup v2: add backup profile to base backup |
| Previous Message | Robert Haas | 2014-10-06 15:50:07 | Re: [RFC] Incremental backup v2: add backup profile to base backup |