| From: | Marti Raudsepp <marti(at)juffo(dot)org> |
|---|---|
| To: | Ali Akbar <the(dot)apaan(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Платон Малюгин <malugin(dot)p(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add generate_series(numeric, numeric) |
| Date: | 2014-10-06 14:26:38 |
| Message-ID: | CABRT9RA6YzXnS=xBgPpBTVUF1zthF6MojpGSv24ZWNxRLua4Aw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I'm a bit confused about who I should be replying to, but since you
were the last one with a patch...
On Mon, Oct 6, 2014 at 11:44 AM, Ali Akbar <the(dot)apaan(at)gmail(dot)com> wrote:
> Thanks for the review. Attached the formatted patch according to your
> suggestion.
+ select * from generate_series(0.1::numeric, 10.0::numeric, 0.1::numeric);
+ generate_series
+ -----------------
+ 0.1
...
+ 10.0
+ (100 rows)
Unless there is a good reason, can you please keep individual test
output fewer than 100 lines? I think the 41-line result is an overkill
as well. This just bloats the repository size unnecessarily.
Also, I see that this patch was added to the 2014-10 commitfest and
then deleted again (by user apaan). Why?
Regards,
Marti
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-10-06 14:46:09 | Re: Patch to support SEMI and ANTI join removal |
| Previous Message | Marti Raudsepp | 2014-10-06 14:13:48 | Re: CREATE IF NOT EXISTS INDEX |