Re: Hot Standby conflict resolution handling

On Thu, Jan 17, 2013 at 9:26 AM, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>wrote:

> At 2012-12-29 14:23:45 -0500, sfrost(at)snowman(dot)net wrote:
> >
> > Regarding the actual comment, here's the wording that I'd use:
>
> Sorry for nitpicking, but "we can't long jumps" made me cringe.
> Here's a slightly more condensed version:
>
> /*
> * We can't use ereport(ERROR) here, because any longjmps
> * in DoingCommandRead state run the risk of violating our
> * protocol or the SSL protocol, by interrupting OpenSSL in
> * the middle of changing its internal state.
> *
> * Currently, the only option is to promote ERROR to FATAL
> * until we figure out a better way to handle errors in this
> * state.
> */
>
> Patch along these lines attached, which also removes trailing
> whitespace from the original patch.
>
>
Thanks Stephen and Abhijit for improving the comments. I like this wording.
So +1 from my side. Abhijit, do you want to add the patch and change the CF
status appropriately ?

Thanks,
Pavan

--
Pavan Deolasee
http://www.linkedin.com/in/pavandeolasee