Re: Does PostgreSQL have complete functional test cases?

From: Tianyin Xu <tixu(at)cs(dot)ucsd(dot)edu>
To: Craig Ringer <craig(at)2ndquadrant(dot)com>
Cc: "pgsql-general(at)postgresql(dot)org" <pgsql-general(at)postgresql(dot)org>
Subject: Re: Does PostgreSQL have complete functional test cases?
Date: 2012-11-09 01:37:22
Message-ID: CABBDWwf761JOHJf2JsRmvoNNkv1+Aj+kpVw2n_iKgn9NxqWYkg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

Thanks, Craig,

Yes, I know "context diff". What I don't know is whether + or - some rows
is a big problem, let's say correctness problem. I didn't write the test
cases so I don't know what these test cases are exactly doing.
If you tell me the failure of these test cases are severe and not
acceptable, I'm fine with it. It means these configurations are not
allowed.

For this particular case, I figured out that it's because of the following
settings,

cpu_index_tuple_cost = 2147483647

which assigned a big number to the cpu_index_tuple_cost, affecting the
query planner.

But to me, the configuration settings should not affect the correctness,
right? Because whatever optimizations you do, the results should be the
same (what matters is the performance). And that's why I need testing
before adjusting these values.

T

On Thu, Nov 8, 2012 at 3:29 PM, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:

> On 11/09/2012 03:28 AM, Tianyin Xu wrote:
>
> Thanks a lot, Pavel, Jeff, Andres!
>
> I just changed the configuration file, postgresql.conf.
>
> Using the default one, all the regress tests are passed (so it should not
> be the block size?). But when I changed something, quite a number of tests
> are failed.
>
>
> Changed "something". What did you change?
>
>
> ! 0 | 998 | 0 | 0 | 0 | 0 | 0 | 0
> | 0 | 0 | 0 | 0 | 1 | AAAAAA | KMBAAA |
> OOOOxx
> 1 | 214 | 1 | 1 | 1 | 1 | 1 | 1
> | 1 | 1 | 1 | 2 | 3 | BAAAAA | GIAAAA |
> OOOOxx
> 2 | 326 | 0 | 2 | 2 | 2 | 2 | 2
> | 2 | 2 | 2 | 4 | 5 | CAAAAA | OMAAAA |
> OOOOxx
> 3 | 431 | 1 | 3 | 3 | 3 | 3 | 3
> | 3 | 3 | 3 | 6 | 7 | DAAAAA | PQAAAA |
> VVVVxx
> - 4 | 833 | 0 | 0 | 4 | 4 | 4 | 4
> | 4 | 4 | 4 | 8 | 9 | EAAAAA | BGBAAA |
> HHHHxx
> 5 | 541 | 1 | 1 | 5 | 5 | 5 | 5
> | 5 | 5 | 5 | 10 | 11 | FAAAAA | VUAAAA |
> HHHHxx
> - 6 | 978 | 0 | 2 | 6 | 6 | 6 | 6
> | 6 | 6 | 6 | 12 | 13 | GAAAAA | QLBAAA |
> OOOOxx
> 7 | 647 | 1 | 3 | 7 | 7 | 7 | 7
> | 7 | 7 | 7 | 14 | 15 | HAAAAA | XYAAAA |
> VVVVxx
> 8 | 653 | 0 | 0 | 8 | 8 | 8 | 8
> | 8 | 8 | 8 | 16 | 17 | IAAAAA | DZAAAA |
> HHHHxx
> ! 9 | 49 | 1 | 1 | 9 | 9 | 9 | 9
> | 9 | 9 | 9 | 18 | 19 | JAAAAA | XBAAAA |
> HHHHxx
>
>
>
> This is a context diff. http://en.wikipedia.org/wiki/Diff#Context_format .
>
> Lines beginning with + mean the line is added. Lines with - mean the line
> is removed. Lines with ! mean the line is changed.
>
> Here, you can see that two rows are not output that should be, and two
> others are output with different-than-expected values; they could've been
> swapped with each other, or just have totally unexpected values. See the
> expected/ files for the output that should be produced.
>
> --
> Craig Ringer
>

--
Tianyin XU,
http://cseweb.ucsd.edu/~tixu/

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message 高健 2012-11-09 01:48:52 Re: Use order by clause, got index scan involved
Previous Message Tom Lane 2012-11-09 01:12:09 Re: Unexpectedly high disk space usage