Re: BUG #14243: pg_basebackup failes by a STATUS_DELETE_PENDING file

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, TAKATSUKA Haruka <harukat(at)sraoss(dot)co(dot)jp>, PostgreSQL Bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #14243: pg_basebackup failes by a STATUS_DELETE_PENDING file
Date: 2016-09-21 04:17:04
Message-ID: CAB7nPqTsGWnQaJe4z=Dw4J_HkftM+roo7MrUMPv9+zSibTqvwg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Wed, Aug 24, 2016 at 9:09 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Mon, Aug 22, 2016 at 11:00 PM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> On Mon, Aug 22, 2016 at 10:48 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>>> On Mon, Aug 22, 2016 at 3:42 PM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
>>> wrote:
>>>> By the way, in your patch you really need to
>>>> s/STATUS_DELETE_PENDING/ERROR_DELETE_PENDING or compilation just
>>>> fails.
>>>
>>> Hah. Yeah, that patch was coded-without-compiling as a poc of how to do it.
>>> Would've definitely needed a round of testing before applying :)
>>
>> As long as I look at that, it gives the attached.
>>
>> Takatsuka-san, others, it would be great if you could test this patch
>> and see if the problem goes away as I have not been able to reproduce
>> the bug myself..
>
> I have added an entry in the CF for that:
> https://commitfest.postgresql.org/10/737/

I gave this bug another try and let Windows run for some time but I
cannot reproduce the original failure even with manual checkpointing
and aggressive checkpoint_timeout, while truncating relations heavily
with pgbench to enforce the deletion of relfilenodes. To all, do you
think that having a large relfilenode file matters to trigger this
issue?

Could it be possible to get more testing as well? We won't go far as
long as we have not checked that the issue gets fixed by the proposed
patch in a place where the problem is able to show up.
--
Michael

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2016-09-21 06:50:18 Re: BUG #14326: Unexpected status after crash during exclusive backup
Previous Message zoulx1982 2016-09-21 03:51:14 BUG #14330: can not select into `composite data types` in plpgsql