From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Magnus Hagander <magnus(at)hagander(dot)net> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_basebackup stream xlog to tar |
Date: | 2016-09-01 12:39:12 |
Message-ID: | CAB7nPqThwVsfUJS2ieRv6RyFTUQ9bvsgzuo0VM2ZtR9+90aiQQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Sep 1, 2016 at 5:13 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> We don't seem to check for similar issues as the one just found in the
> existing tests though, do we? As in, we don't actually verify that the xlog
> files being streamed are 16Mb? (Or for that matter that the tarfile emitted
> by -Ft is actually a tarfile?) Or am I missing some magic somewhere? :)
No. There is no checks on the WAL file size (you should use the output
of pg_controldata to see how large the segments should be). For the
tar file, the complication is in its untar... Perl provides some ways
to untar things, though the oldest version that we support in the TAP
tests does not offer that :(
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-09-01 12:47:09 | Re: GiST penalty functions [PoC] |
Previous Message | Tom Lane | 2016-09-01 12:31:38 | Re: new gcc warning |