| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_upgrade in 9.5 broken for adminpack |
| Date: | 2015-04-17 07:11:44 |
| Message-ID: | CAB7nPqTN6aOFmNT4+VZKWOE7JYaG5PZVx+Kb3N6DLe=mNd1mdA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Apr 17, 2015 at 3:29 PM, Jeff Janes wrote:
> Of course after sending that it became obvious. The C function is not
> getting called because the SQL function is marked as being strict, yet is
> called with NULL arguments.
>
> Trivial patch attached to unset strict flag in pg_proc.h.
>
> But CATALOG_VERSION_NO probably needs another bump as well.
This looks good to me. I have tested your fix and the problem goes
away. create_empty_extension() was the only function not declared as
STRICT before 30982be4 (see install_support_functions_in_new_db() in
contrib/pg_upgrade/function.c).
Regards,
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2015-04-17 07:22:43 | Re: Moving on to close the current CF 2015-02 |
| Previous Message | Jeff Janes | 2015-04-17 06:29:07 | Re: pg_upgrade in 9.5 broken for adminpack |