| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
| Cc: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: vac truncation scan problems |
| Date: | 2015-04-01 01:49:55 |
| Message-ID: | CAB7nPqTMBd6=5i3ZOg9t6A0km4VZ=wNt4_rwOzPVm683-aQ=Qw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 1, 2015 at 2:18 AM, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:
> On Tue, Mar 31, 2015 at 1:28 AM, Kyotaro HORIGUCHI <
> horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>
>> Hi, this is a bug in the commit 0d831389749a3baaced7b984205b9894a82444b9 .
>>
>> It allows vucuum freeze to be skipped and inversely lets regular
>> vacuum wait for lock. The attched patch fixes it.
>>
>>
>> In table_recheck_autovac, vacuum options are determined as following,
>>
>> > tab->at_vacoptions = VACOPT_SKIPTOAST |
>> > (dovacuum ? VACOPT_VACUUM : 0) |
>> > (doanalyze ? VACOPT_ANALYZE : 0) |
>> !> (wraparound ? VACOPT_NOWAIT : 0);
>>
>> The line prefixed by '!' looks inverted.
>>
>
> Thanks, it is obvious once you see it!
>
Nice catch, Horiguchi-san.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2015-04-01 03:01:28 | pg_restore -t should match views, matviews, and foreign tables |
| Previous Message | Peter Eisentraut | 2015-04-01 01:48:39 | Re: libpq's multi-threaded SSL callback handling is busted |