| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Gilles Darold <gilles(dot)darold(at)dalibo(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, "Karl O(dot) Pinc" <kop(at)meme(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch to implement pg_current_logfile() function |
| Date: | 2017-03-03 06:24:53 |
| Message-ID: | CAB7nPqTGe9xtXhTJj5487e0qXdr5Q0yhVL34xYVzbmhOU+dDtw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 3, 2017 at 3:18 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> Hopefully I haven't broken anything; please let me know if you
> encounter any issues.
Reading what has just been committed...
+ /*
+ * No space found, file content is corrupted. Return NULL to the
+ * caller and inform him on the situation.
+ */
+ elog(ERROR,
+ "missing space character in \"%s\"", LOG_METAINFO_DATAFILE);
+ break;
There is no need to issue a break after a elog(ERROR).
+ * No newlinei found, file content is corrupted. Return NULL to
s/newlinei/newline/
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2017-03-03 06:25:09 | Re: \if, \elseif, \else, \endif (was Re: PSQL commands: \quit_if, \quit_unless) |
| Previous Message | Fabien COELHO | 2017-03-03 06:19:11 | Re: \if, \elseif, \else, \endif (was Re: PSQL commands: \quit_if, \quit_unless) |