| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Ian Barwick <ian(at)2ndquadrant(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Subject: | Re: Correction for replication slot creation error message in 9.6 |
| Date: | 2016-03-31 01:48:11 |
| Message-ID: | CAB7nPqTAhp4QSkPkNQnXGRDVzVg8atHbMokqD0dWmHeSf9f+QA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 31, 2016 at 10:15 AM, Ian Barwick <ian(at)2ndquadrant(dot)com> wrote:
> Currently pg_create_physical_replication_slot() may refer to
> the deprecated wal_level setting "archive":
(Adding Peter in CC who committed this patch).
> Patch changes the error message to:
>
> ERROR: replication slots can only be used if wal_level is "replica" or "logical"
Sounds right to me.
> Explicitly naming the valid WAL levels matches the wording in the wal_level
> error hint used in a couple of places, i.e.
>
> "wal_level must be set to "replica" or "logical" at server start."
It is worth telling that Peter and I both had this code in front of
our eyes during the review :) Still we missed that.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Steele | 2016-03-31 02:00:31 | Re: Updated backup APIs for non-exclusive backups |
| Previous Message | Peter Geoghegan | 2016-03-31 01:38:31 | Re: Please correct/improve wiki page about abbreviated keys bug |