Re: Bug in pg_dump

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Gilles Darold <gilles(dot)darold(at)dalibo(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Bug in pg_dump
Date: 2015-03-02 01:59:50
Message-ID: CAB7nPqT7uxanAa10b+MGtphc0e-aD9W4XajpiEv1A+Jbtmm2mQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Mar 2, 2015 at 6:27 AM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> Please see the latest version of this, attached. I've removed the left
> join, re-used the 'query' buffer (instead of destroying and recreating
> it), and added a bit of documentation, along with a note in the commit
> message for the release notes.

Thanks, those modifications look good to me.

> Would be great if you could review it and let me know. As mentioned in
> my other email, I'm happy to include the TAP test in master once we've
> worked out the correct way to handle installing the extension for
> testing in the Makefile system.

Sure. As that's unrelated to this thread, perhaps we could discuss
this point on another thread with refreshed patches? I'd like to hear
some input from Peter on the matter as well.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2015-03-02 02:55:24 Re: Odd behavior of updatable security barrier views on foreign tables
Previous Message Heikki Linnakangas 2015-03-01 22:43:23 Re: Index-only scans for GiST.