| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9. |
| Date: | 2016-03-22 01:31:28 |
| Message-ID: | CAB7nPqT+tAPcH9BuZrp95ggDRJPhseVEW_HH8eeFpev8H6tUQA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Tue, Mar 22, 2016 at 10:20 AM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
>
> On 03/21/2016 09:25 AM, Tom Lane wrote:
>>
>> Andres Freund <andres(at)anarazel(dot)de> writes:
>>>
>>> On 2016-03-21 22:38:50 +1300, David Rowley wrote:
>>>>
>>>> Perl is not my native tongue, but after a little study and some
>>>> testing on a windows machine, the attached seems to fix the problem.
>>>
>>> I've pushed this, as I would like the buildfarm to be green before
>>> pushing the latch rework...
>>
>> Thanks! If Andrew or somebody has a nicer solution, they can improve
>> this later.
>
> I've reviewed the changes briefly. They seem sane enough, although the code
> could do with a little logical reordering.
We're stuck with the list of files defined in OBJS, and psql's
Makefile is listing psqlscan.o, so that's still the best way to go.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2016-03-22 13:05:42 | pgsql: Fix typo in docs. |
| Previous Message | Andrew Dunstan | 2016-03-22 01:20:37 | Re: pgsql: Best-guess attempt at fixing MSVC build for 68ab8e8ba4a471d9. |