Re: GinPageIs* don't actually return a boolean

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Yury Zhuravlev <u(dot)zhuravlev(at)postgrespro(dot)ru>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: GinPageIs* don't actually return a boolean
Date: 2016-03-19 12:43:25
Message-ID: CAB7nPqSzWSAo48ct3LKQSiCW4dF0t=uRaqviV4eh3HS69OJuhQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Mar 19, 2016 at 12:08 AM, Yury Zhuravlev
<u(dot)zhuravlev(at)postgrespro(dot)ru> wrote:
> Michael Paquier wrote:
>>
>> FWIW, when compiling with MS 2015 using the set of perl scripts I am
>> not seeing this compilation error...
>
> This error not in build stage but in GIN regresion tests. CMake nothing to
> do with.

Bingo: "right sibling of GIN page is of different type", and gin is
not the only test to fail, there are 4 tests failing including gin,
and all the failures are caused by that. So yes, we had better fix it.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2016-03-19 13:29:14 Re: Idle In Transaction Session Timeout, revived
Previous Message Michael Paquier 2016-03-19 12:30:11 Re: Password identifiers, protocol aging and SCRAM protocol