| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | marian(dot)krucina(at)gmail(dot)com, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: BUG #13907: Restore materialized view throw permission denied |
| Date: | 2016-06-22 09:38:25 |
| Message-ID: | CAB7nPqSwdqLi-j9XPa9HP2fn80G=jQ31bJzAcT4vfX6D1nWBkA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Fri, Jun 17, 2016 at 2:59 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> Attached is a new patch, with the promised refactoring, more
> regression tests, etc. After some thoughts, I have arrived to the
> conclusion that it is better to limit the footprint of this patch in
> views.c. So I have created a routine makeColumnDef that is used for
> views, ctas and matviews, but I am letting the creation of the column
> definition list separated as each code path has slight differences
> when building it. Things could be made more shared on HEAD but that
> would be really intrusive for back branches, and I have kept that in
> mind for this patch.
>
> Comments?
Patch is added to the next commit fest. I don't want this thing to be
lost in translation:
https://commitfest.postgresql.org/10/652/
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Konstantin Belousov | 2016-06-22 10:00:14 | Re: BUG #14206: Switch to using POSIX semaphores on FreeBSD |
| Previous Message | ugostray | 2016-06-22 03:14:30 | BUG #14207: A little is lacking to be the most advanced |