| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: fd.c: flush data problems on osx |
| Date: | 2016-04-02 08:03:22 |
| Message-ID: | CAB7nPqSSQEuVaXRa90rdeH5LMXGqNNrCy4D-XuiJ3TzC4aQDxw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 21, 2016 at 9:09 PM, Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru> wrote:
> On 21 Mar 2016, at 14:53, Andres Freund <andres(at)anarazel(dot)de> wrote:
>> Hm. I think we should rather just skip calling pg_flush_data in the
>> directory case, that very likely isn't beneficial on any OS.
>
> Seems reasonable, changed.
>
>> I think we still need to fix the mmap() implementation to support the
>> offset = 0, nbytes = 0 case (via fseek(SEEK_END).
>
> It is already in this diff. I’ve added this few messages ago.
A similar change seems to be needed in initdb.c's pre_sync_fname.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2016-04-02 10:26:35 | Re: Performance improvement for joins where outer side is unique |
| Previous Message | Fabien COELHO | 2016-04-02 06:27:29 | Re: pgbench - remove unused clientDone parameter |