| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, David Steele <david(at)pgmasters(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, David Fetter <david(at)fetter(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Julian Markwort <julian(dot)markwort(at)uni-muenster(dot)de>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Valery Popov <v(dot)popov(at)postgrespro(dot)ru> |
| Subject: | Re: Password identifiers, protocol aging and SCRAM protocol |
| Date: | 2016-09-02 21:11:54 |
| Message-ID: | CAB7nPqSO74M3_V8Ytd4RLDofyY-E+iSShKfYkE-TWYx2w4y=ZQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 2, 2016 at 10:59 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
>> Before I send a new series of patches... There is one thing that I am
>> still troubled with: the compilation of pgcrypto. First from
>> contrib/pgcrypto/Makefile I am noticing the following issue with this
>> block:
>> CF_SRCS = $(if $(subst no,,$(with_openssl)), $(OSSL_SRCS), $(INT_SRCS))
>> CF_TESTS = $(if $(subst no,,$(with_openssl)), $(OSSL_TESTS), $(INT_TESTS))
>> CF_PGP_TESTS = $(if $(subst no,,$(with_zlib)), $(ZLIB_TST), $(ZLIB_OFF_TST))
>> How is that correct if src/Makefile.global is not loaded first?
>> Variables like with_openssl are still not loaded at that point.
>
> Um, you do know that Make treats "=" definitions of variables as,
> essentially, macro definitions? The fact that with_openssl isn't
> set yet doesn't necessarily mean these definitions are wrong.
> Is it actually not working for you, or are you just not understanding
> why it works?
Oops right. I was trying to use an ifeq on $with_openssl, and that did
not work but just using that would go correctly...
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Nasby | 2016-09-02 23:20:48 | (Comment)Bug in CteScanNext |
| Previous Message | Bruce Momjian | 2016-09-02 21:07:30 | Re: System load consideration before spawning parallel workers |