Re: contribcheck and modulescheck of MSVC's vcregress.pl cannot work independently

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>, peter_e(at)gmx(dot)net
Subject: Re: contribcheck and modulescheck of MSVC's vcregress.pl cannot work independently
Date: 2015-07-12 12:50:42
Message-ID: CAB7nPqSBEUtZQJeHoKAZjYcUs=T7Dyv56OYK5Ga9Eu2MbHmv=A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Sun, Jul 12, 2015 at 3:57 PM, Noah Misch <noah(at)leadboat(dot)com> wrote:

> On Mon, Jul 06, 2015 at 11:53:58PM -0700, Michael Paquier wrote:
> > On Mon, Jul 6, 2015 at 10:04 PM, Noah Misch wrote:
> > >> Also, if we would
> > >> want to have a real installcheck mode, what we should use is not the
> > >> path to what has been built but the path to the installation that the
> > >> Postgres instance needed is using. Now if you want to fix it if you
> > >> fix that's incorrect I won't complain about that :)
> > >
> > > I don't wish to. I was content with released-branch vcregress.pl
> semantics.
> >
> > Attached is a patch to revert to the pre-9.4 way of doing...
>
> This is a start. Study "git diff REL9_4_STABLE src/tools/msvc/
> vcregress.pl"
> after applying it. To give just one example of material left to revert, it
> leaves two absolute-path "chdir" calls in a row.
>

Then the attached I guess addresses your concerns..
--
Michael

Attachment Content-Type Size
20150712_light_tempinstall.patch text/x-diff 2.5 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Bommarito 2015-07-12 18:09:09 Re: BUG #13490: Segmentation fault on pg_stat_activity
Previous Message Jaimin Pan 2015-07-12 12:21:10 [Postgresql Master Branch Patch] object class patch