Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list
Date: 2016-10-24 04:51:25
Message-ID: CAB7nPqS4mVN-TEFdr+Qsou9HEegDDbMeTMhCG-RgOWesLTvkiA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

(Moved to -hackers)

On Sun, Oct 23, 2016 at 10:57 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> Remove extra comma at end of enum list
>
> C99-specific feature, and wasn't intentional in the first place.
>
> Per buildfarm member mylodon

This is the second time I see that in the last couple of weeks. Would
it be better to use some custom CFLAGS to detect that earlier in the
review process? I have never much used gcc's std or clang extensions
in this area. Has somebody any recommendations?
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Fabien COELHO 2016-10-24 06:36:55 Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list
Previous Message Tom Lane 2016-10-24 02:14:08 pgsql: Release notes for 9.6.1, 9.5.5, 9.4.10, 9.3.15, 9.2.19, 9.1.24.

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2016-10-24 04:58:20 Re: issue with track_commit_timestamp and server restart
Previous Message Michael Paquier 2016-10-24 04:46:39 Re: pg_basebackup stream xlog to tar