| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | David Steele <david(at)pgmasters(dot)net> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Subject: | Re: Streaming basebackups vs pg_stat_tmp |
| Date: | 2016-10-29 13:12:27 |
| Message-ID: | CAB7nPqRy88wjbRZL2tyWWYb1td0BMcdPaehwmu0VWxv6mj3fMQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 28, 2016 at 9:57 PM, David Steele <david(at)pgmasters(dot)net> wrote:
> On 10/28/16 3:49 PM, Magnus Hagander wrote:
> The change from 10 to 11 increases the tests that are skipped on Windows,
> which is necessary because one extra symlink test is added.
>
> I think you need:
>
> [...]
>
> The rest of the tests are for exclusions.
Indeed, giving the attached for REL9_6_STABLE. You could as well have
a test for pg_stat_tmp but honestly that's not worth it. One thing I
have noticed is that the patch does not use _tarWriteDir() for
pg_xlog. I think it should even if that's not addressing directly a
bug...
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| basebackup_symlink_fix_v2.patch | text/x-diff | 4.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2016-10-29 19:23:34 | Re: multivariate statistics (v19) |
| Previous Message | Karl O. Pinc | 2016-10-29 12:38:26 | Re: Patch to implement pg_current_logfile() function |