| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_stat_archiver issue with aborted archiver |
| Date: | 2015-06-08 03:56:47 |
| Message-ID: | CAB7nPqRY4YsNb1tONBLvg2AbmnYyq02LKKfuYWLootuBA-O8CQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Jun 7, 2015 at 1:11 AM, Julien Rouhaud
<julien(dot)rouhaud(at)dalibo(dot)com> wrote:
> I just noticed that if the archiver aborts (for instance if the
> archive_command exited with a return code > 127), pg_stat_archiver won't
> report those failed attempts. This happens with both 9.4 and 9.5 branches.
>
> Please find attached a patch that fix this issue, based on current head.
The current code seems right to me. When the archive command dies
because of a signal (exit code > 128), the server should fail
immediately with FATAL and should not do any extra processing. It will
also try to archive again the same segment file after restart. When
trying again, if this time the failure is not caused by a signal but
still fails it will be reported to pg_stat_archiver.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2015-06-08 04:08:25 | Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file |
| Previous Message | Abhijit Menon-Sen | 2015-06-08 03:42:49 | skipping pg_log in basebackup (was Re: pg_basebackup and pg_stat_tmp directory) |