| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Christian Ullrich <chris(at)chrullrich(dot)net> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Noah Misch <noah(at)leadboat(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: pgsql: Add putenv support for msvcrt from Visual Studio 2013 |
| Date: | 2016-11-30 21:07:16 |
| Message-ID: | CAB7nPqRRL0DJPmXZMvsGf5avo3Sm_zVCbrPi_LOJtu1eBRexag@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Thu, Dec 1, 2016 at 1:24 AM, Christian Ullrich <chris(at)chrullrich(dot)net> wrote:
> * From: Michael Paquier
>
>> With 0005 I am seeing a compilation failure: you need to have the
>> declarations in the _MSC_VER block at the beginning of the routine. It
>
> Sorry, too used to C++.
>
>> would be nice to mention in a code comment that this what Noah has
>> mentioned upthread: if a CRT loads while pgwin32_putenv() is
>> executing, the newly-loaded CRT will always have the latest value.
>
> I fixed the existing comment by removing the last sentence that is in the wrong place now, but I don't see the point in suddenly starting to explain why it is done this way and not the other.
>
>> Based on that 0006 will need a rebase, nothing huge though.
>
> Done, new revisions attached.
Okay, switched as ready for committer.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2016-12-01 00:22:08 | pgsql: Perform one only projection to compute agg arguments. |
| Previous Message | Robert Haas | 2016-11-30 20:43:41 | pgsql: Improve hash index bucket split behavior. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2016-11-30 21:37:58 | Re: Logical Replication WIP |
| Previous Message | Robert Haas | 2016-11-30 20:48:01 | Re: Hash Indexes |