| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: [BUG] pg_basebackup from disconnected standby fails |
| Date: | 2016-10-27 13:05:45 |
| Message-ID: | CAB7nPqRQY7_jfL1xKMze3gyLxMdYejC-a1rmx5kW3x7yYGKJgA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 27, 2016 at 7:16 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> This can create problem if the checkpoint record spans across multiple
> segments, because you are updating minRecoveryPoint to start of
> checkpoint record. We need to update it to end+1 of checkpoint
> record. Please find attached patch which takes care of same.
I gave up counting my mistakes on this thread, thanks. You should
update the comments of XLogCtlData for the new field
lastCheckPointEndPtr so as it is not used by the background writer but
when creating a new restart point to define the minimum recovery
point.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mithun Cy | 2016-10-27 13:46:05 | Re: Patch: Implement failover on libpq connect level. |
| Previous Message | Fabien COELHO | 2016-10-27 12:52:17 | Re: [PATCH] pgpassfile connection option |