Re: pg_hba_file_settings view patch

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Josh Berkus <josh(at)agliodbs(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_hba_file_settings view patch
Date: 2016-10-27 00:33:10
Message-ID: CAB7nPqQwHO3RSQ1Wwr75hCoZUHL0de=0X2EbttHmt3UKMa+wmA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Oct 27, 2016 at 5:11 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Josh Berkus <josh(at)agliodbs(dot)com> writes:
>> On 10/26/2016 12:24 PM, Tom Lane wrote:
>>> I concur. JSON isn't a core datatype and I don't want to see it treated
>>> as one. We should redesign this view so that it doesn't rely on anything
>>> more advanced than arrays.
>
>> Huh? Sure it is. Ships in PostgreSQL-core.
>
> To my way of thinking it's a nonstandard extension. The fact that we
> chose to package it in core and not as an extension doesn't alter the
> fact that it's peripheral to the system and nothing else depends on it.
> I'd like to keep things that way. I wouldn't want any core-system
> functionality to start depending on the geometric types, either.

I got a similar opinion regarding this patch to be honest after
looking at it, seeing actually with a bad eye the use of fancy data
types that are not well-spread among the other catalog views and
functions. So -1 for JSON and +1 for arrays.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2016-10-27 00:33:34 Re: CLUSTER, reform_and_rewrite_tuple(), and parallelism
Previous Message Kyotaro HORIGUCHI 2016-10-27 00:08:32 Re: Unused variable in postgres_fdw/deparse.c