| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Andreas Seltenreich <seltenreich(at)gmx(dot)de> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: [sqlsmith] FailedAssertion("!(XLogCtl->Insert.exclusiveBackup)", File: "xlog.c", Line: 10200) |
| Date: | 2016-08-05 03:16:13 |
| Message-ID: | CAB7nPqQeMQ8K3Vwh+T7Gq0O3i-3kiRyNPue9WRgqJQVuFAbZrQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 4, 2016 at 4:38 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> Andreas, with the patch attached is the assertion still triggered?
>
> Thoughts from others are welcome as well.
Self review:
* of streaming base backups currently in progress. forcePageWrites is set
* to true when either of these is non-zero. lastBackupStart is the latest
* checkpoint redo location used as a starting point for an online backup.
+ * exclusiveBackupStarted is true while pg_start_backup() is being called
+ * during an exclusive backup.
*/
bool exclusiveBackup;
int nonExclusiveBackups;
XLogRecPtr lastBackupStart;
+ bool exclusiveBackupStarted;
It would be better to just use one variable that uses an enum to track
the following states of an exclusive backup: none, starting and
in-progress.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2016-08-05 03:40:46 | Re: PostgreSQL 10 Roadmaps |
| Previous Message | Robert Haas | 2016-08-05 02:58:28 | Re: pgsql: Prevent "snapshot too old" from trying to return pruned TOAST tu |