Re: PostgresNode::_update_pid using undefined variables in tap tests

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Subject: Re: PostgresNode::_update_pid using undefined variables in tap tests
Date: 2015-12-09 02:29:31
Message-ID: CAB7nPqQSoUi8W1HeuzkcDkf_tSus11tqe=mX8vYVryVURbp6=w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Dec 9, 2015 at 11:23 AM, Robert Haas wrote:
> Boy, that's awful. Whoever designed that bit of wonderfulness should
> have their language design license revoked.

If one would want to work on a check with pidfile, he/she could check
for tell($pidfile) == -1 which corresponds to an undetermined
position, that's ugly but we need to live with that.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2015-12-09 02:39:13 Re: Using quicksort for every external sort run
Previous Message Robert Haas 2015-12-09 02:23:31 Re: PostgresNode::_update_pid using undefined variables in tap tests