| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | ALTER SYSTEM SET typos and fix for temporary file name management |
| Date: | 2014-01-18 14:29:02 |
| Message-ID: | CAB7nPqQ7RdVgJac7Dgv6B_GQs+H8VA51q1RQS3DEWM+463fbOQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all,
After going through commit 65d6e4c (introducing ALTER SYSTEM SET), I
noticed a couple of typo mistakes as well as (I think) a weird way of
using the temporary auto-configuration name postgresql.auto.conf.temp
in two different places, resulting in the patch attached.
It might be an overkill to use a dedicated variable for the temporary
autoconfiguration file (here PG_AUTOCONF_FILENAME_TEMP), but I found
kind of weird the way things are currently done on master branch. IMO,
it would reduce bug possibilities to have everything managed with a
single variable.
Typos at least should be fixed :)
Regards,
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 20140118_alter_system_fix.patch | text/x-diff | 4.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2014-01-18 14:59:53 | Re: Deprecations in authentication |
| Previous Message | Florian Pflug | 2014-01-18 14:22:10 | Re: [PATCH] Negative Transition Aggregate Functions (WIP) |