XLOG_PARAMETER_CHANGE (WAL record) missing two params in its desc routine

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: XLOG_PARAMETER_CHANGE (WAL record) missing two params in its desc routine
Date: 2014-12-05 02:54:15
Message-ID: CAB7nPqQ-x=JU1R6a+Jx-wmcTnFWWLneWEPyLD+re6R23=1YnJw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

While reading the code in this area this morning, I noticed that
wal_log_hints and track_commit_timestamp are not mentioned in the desc
routine of XLOG_CHANGE_PARAMETER. Also, it is not mentioned in
postgresql.conf.sample that a value update of wal_log_hints requires a
system restart.

In order to fix those things, attached are two patches:
- patch 1 should be applied back to 9.4 where wal_log_hints has been added
- patch 2 is master-only, and needs to be applied on top of patch 1.
Regards,
--
Michael

Attachment Content-Type Size
0001-Fix-wal_log_hints-management-in-xlog-resource-manage.patch application/x-patch 2.1 KB
0002-Mention-update-of-track_commit_timestamps-in-XLOG_PA.patch application/x-patch 1.2 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Adam Brightwell 2014-12-05 05:29:57 check-world failure: dummy_seclabel
Previous Message Robert Haas 2014-12-05 01:53:35 Re: [REVIEW] Re: Compression of full-page-writes