| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: add modulo (%) operator to pgbench |
| Date: | 2015-01-05 08:30:30 |
| Message-ID: | CAApHDvrRMadf9BTSuMXsNJbx2Psz9fHiKFPcxWKOMO5F9sOfvA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 1 January 2015 at 21:23, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
>
> I was about to go and look at this, but I had a problem when attempting to
>> compile with MSVC.
>>
>
> Thanks! Here is a v4 which includes your fix.
>
>
I'm also just looking at you ERROR() macro, it seems that core code is
quite careful not to use __VA_ARGS__ on compilers where HAVE__VA_ARGS is
not defined. I'd say this needs to be fixed too. Have a look at the trick
used in elog.h for when HAVE__VA_ARGS is not defined.
Regards
David Rowley
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2015-01-05 09:07:23 | Re: Compression of full-page-writes |
| Previous Message | Michael Paquier | 2015-01-05 08:16:43 | Re: Patch: add recovery_timeout option to control timeout of restore_command nonzero status code |