From: | Thom Brown <thombrown(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Command Triggers, v16 |
Date: | 2012-03-16 19:51:35 |
Message-ID: | CAA-aLv45hV6rP1wR05moTt77AjXDC+4fhAiQXiJY-xzGFJ=abw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 16 March 2012 16:26, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr> writes:
>> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
>>> If you think "cmdtrigger" isn't a good name maybe you should have
>>> picked a different one to start with.
>
>> Well, I think it's a good internal name. I'm not too sure about exposing
>> it, the only reason why it's a good name is because it's a single not
>> too long word, after all. Not very “SQLish”.
>
>> I'm putting cmdtrigger as the user visible name in the next version of
>> the patch, if you come up with something potentially more user friendly
>> feel free to suggest.
>
> How about "commandtrigger" or "command_trigger"? Typing a few more
> characters in this context doesn't seem like a deal-breaker to me.
+1
No objections to either of those suggestions, although I'd lean
towards the one without the underscore, not for any technical reason.
There is a precedent for a type with an underscore in its name
(txid_snapshot) but seems to be the exception.
Thom
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2012-03-16 20:54:47 | Re: Command Triggers, patch v11 |
Previous Message | Alvaro Herrera | 2012-03-16 19:13:41 | Re: BUG #6510: A simple prompt is displayed using wrong charset |