| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Kevin Grittner <kgrittn(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>, Kyle Kingsbury <aphyr(at)jepsen(dot)io>, Ashwin Agrawal <aagrawal(at)pivotal(dot)io> |
| Subject: | Re: Potential G2-item cycles under serializable isolation |
| Date: | 2020-06-11 10:12:47 |
| Message-ID: | CA+hUKGJrYxibcB6KRK779HgoOQZy1oc6CxeYXdMr0SeM+OYZkg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Tue, Jun 9, 2020 at 2:08 PM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> On Mon, Jun 8, 2020 at 7:01 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > Right, the only change was to move things around a bit to suport new
> > table AMs. Speaking of which, it looks like the new comment atop
> > CheckForSerializableConflictOut() could use some adjustment. It says
> > "A table AM is reading a tuple that has been modified. After
> > determining that it is visible to us, it should call this function..."
> > but it seems the truth is a bit more complicated than that.
>
> Right. I think that you can go ahead and change it without further input here.
It's only comments, but it'd still be good to get some review since
it's essentially describing the relevant contract. Here's what I came
up with.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Improve-comments-for-Heap-CheckForSerializableConfli.patch | text/x-patch | 3.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-06-11 11:16:48 | Re: pg_stat_statements: duplicated external query texts with MSY2 |
| Previous Message | Daniel Gustafsson | 2020-06-11 09:59:20 | Re: BUG #16484: pg_regress fails with --outputdir parameter |