Re: Re: proposal: make NOTIFY list de-duplication optional

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Filip Rembiałkowski <filip(dot)rembialkowski(at)gmail(dot)com>
Cc: Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Catalin Iacob <iacobcatalin(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>
Subject: Re: Re: proposal: make NOTIFY list de-duplication optional
Date: 2019-03-09 02:30:40
Message-ID: CA+hUKGJh7C+r8wFtOMUoSu9kPOa87tsa2d5cA=0qT2oaay+EEA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Mar 8, 2019 at 1:37 PM Filip Rembiałkowski
<filip(dot)rembialkowski(at)gmail(dot)com> wrote:
> See attached patch... I'm ready to work on so it can get merged in the next CF.

Hi Filip,

Seen on Travis:

async ... FAILED 126 ms

Looks like the new error isn't being raised for invalid send mode?
(What kind of error message is "?" anyway? :-))

ERROR: channel name too long
-- Should fail. Invalid 3rd parameter
NOTIFY notify_async2, 'test', 'invalid';
-ERROR: ?
NOTIFY notify_async2, 'test', true;
-ERROR: ?
--Should work. Valid NOTIFY/LISTEN/UNLISTEN commands
NOTIFY notify_async2;
NOTIFY notify_async2, '';

--
Thomas Munro
https://enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-03-09 03:11:26 Re: Should we increase the default vacuum_cost_limit?
Previous Message Tom Lane 2019-03-09 01:54:11 Re: Should we increase the default vacuum_cost_limit?