From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
---|---|
To: | Euler Taveira de Oliveira <euler(at)timbira(dot)com> |
Cc: | "Satoshi Nagayasu / Uptime Technologies, LLC(dot)" <snaga(at)uptime(dot)jp>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: log messages for archive recovery progress |
Date: | 2012-01-11 10:56:11 |
Message-ID: | CA+U5nMLJxuqj5m2gAJJgAqtwY6B9JQnZ+aEegP_TpYQZs--8Nw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
2012/1/11 Euler Taveira de Oliveira <euler(at)timbira(dot)com>:
> On 08-01-2012 11:59, Satoshi Nagayasu / Uptime Technologies, LLC. wrote:
>>> [2011-12-08 15:14:36 JST] 16758: LOG: restored log file "000000080000000000000046" from archive
>>> [2011-12-08 15:14:36 JST] 16758: LOG: recoverying 000000080000000000000046
>>> [2011-12-08 15:14:36 JST] 16758: LOG: restored log file "000000080000000000000047" from archive
>>> [2011-12-08 15:14:36 JST] 16758: LOG: recoverying 000000080000000000000047
>>> cp: cannot stat `/backups/archlog/000000080000000000000048': No such file or directory
>>> [2011-12-08 15:14:37 JST] 16758: LOG: could not restore file "000000080000000000000048" from archive
>>> [2011-12-08 15:14:37 JST] 16758: LOG: attempting to look into pg_xlog
>>> [2011-12-08 15:14:37 JST] 16758: LOG: recoverying 000000080000000000000048
>>
> What about just 'restored log file "000000080000000000000048" from pg_xlog'
> instead of the last two messages? If you can't read from pg_xlog emit 'could
> not restore file "000000080000000000000048" from pg_xlog'.
Yes, simple is better.
We already have a message if the file is not present, we just need one
if we switch to using pg_xlog.
Please look at this.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Attachment | Content-Type | Size |
---|---|---|
restored_from_xlog.v1.patch | text/x-patch | 1.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Ashutosh Bapat | 2012-01-11 11:43:10 | Confusing EXPLAIN output in case of inherited tables |
Previous Message | Florian Weimer | 2012-01-11 09:33:47 | Re: checkpoint writeback via sync_file_range |