Re: identify_locking_dependencies is broken for schema-only dumps

On Wed, Sep 24, 2014 at 12:18 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> If there are no comments on this soon-ish, I'm going to push and
>> back-patched the patch I attached.
>
> Sorry for not paying attention sooner. After studying it for awhile,
> I think the change is probably all right but your proposed comment is
> entirely inadequate. There are extremely specific reasons why this
> works, and you removed an existing comment about that and replaced it
> with nothing but a wishy-washy "maybe".

Well, I could write something like this:

* We assume the item requires exclusive lock on each TABLE or TABLE DATA
* item listed among its dependencies. (This was originally a dependency on
* the TABLE, but fix_dependencies may have repointed it to the data item.
* In a schema-only dump, however, this will not have been done.)

If you don't like that version, can you suggest something you would like better?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company