Re: citext operator precedence fix

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Josh Berkus <josh(at)agliodbs(dot)com>
Cc: "David E(dot) Wheeler" <david(at)kineticode(dot)com>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: citext operator precedence fix
Date: 2011-09-22 19:01:56
Message-ID: CA+TgmobTsZb2ibu_tUBNONf=2=yK0=40C2GkYWBfxqMW3ayFmA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Sep 22, 2011 at 2:36 PM, Josh Berkus <josh(at)agliodbs(dot)com> wrote:
>> But I don't think we're required to support that case.  If the user
>> does a non-standard install, it's their job to deal with the fallout.
>
> Well, I'll write the script anyway, since *I* need it.  I'm installing
> this on a 9.0 database which will be later upgraded to 9.1.
>
> However, before I write all this, I'd like to settle the question of
> acceptability.  What do I need to do to make it OK to break backwards
> compatibility for this?  I feel strongly that I'm correcting it to the
> behavior users expect, but that's not statistically backed.
>
> I don't want to spend several hours writing scripts so that it can be
> rejected *for that reason*.

I'm OK with the proposed behavior change and I agree that it's
probably what people want, but I am awfully suspicious that those
extra casts are going to break something you haven't thought about.
It might be worth posting a rough version first just to see if I (or
someone else) can break it before you spend a lot of time on it.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2011-09-22 19:12:52 Re: Double sorting split patch
Previous Message Josh Berkus 2011-09-22 18:36:48 Re: citext operator precedence fix