| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Beena Emerson <memissemerson(at)gmail(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: increasing the default WAL segment size |
| Date: | 2017-01-27 22:29:44 |
| Message-ID: | CA+TgmobTJ1hSJNy4fjbA5eqqVvVi-gC7adJk9Uez9oDSMHSHrg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 26, 2017 at 8:53 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
>> I've not done like the most careful review ever, but I'm in favor of the
>> general change (provided the byval thing is fixed obviously).
>
> Thanks for the review.
Why not use pg_ltoa and pg_lltoa like the output functions for the datatype do?
Might use CStringGetTextDatum(blah) instead of
PointerGetDatum(cstring_to_text(blah)).
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Nasby | 2017-01-27 22:34:43 | Re: Proposal : For Auto-Prewarm. |
| Previous Message | Robert Haas | 2017-01-27 22:23:51 | Re: Typo in comment in postgres_fdw.c |