| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, pgsql(at)j-davis(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: new compiler warnings |
| Date: | 2011-10-18 14:15:56 |
| Message-ID: | CA+Tgmob9=0qv5ZzH+ztb2xeccwAnM-gpFXHXsbcTjxfOYo=i7Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 18, 2011 at 10:06 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> No, I believe we are OK everywhere else. We are only ignoring the
> result in cases where we are trying to report errors in the first place.
The relevant code is:
while (len > PIPE_MAX_PAYLOAD)
{
p.proto.is_last = (dest == LOG_DESTINATION_CSVLOG ? 'F' : 'f');
p.proto.len = PIPE_MAX_PAYLOAD;
memcpy(p.proto.data, data, PIPE_MAX_PAYLOAD);
write(fd, &p, PIPE_HEADER_SIZE + PIPE_MAX_PAYLOAD);
data += PIPE_MAX_PAYLOAD;
len -= PIPE_MAX_PAYLOAD;
}
Which it seems to me we could change by doing rc = write(). Then if
rc <= 0, we bail out. If not, we add and subtract rc, rather than
PIPE_MAX_PAYLOAD. That would be barely more code, probably safer, and
would silence the warning.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ahmed Shinwari | 2011-10-18 14:17:28 | Re: [BUG] SSPI authentication fails on Windows when server parameter is localhost or domain name |
| Previous Message | Peter Eisentraut | 2011-10-18 14:06:27 | Re: new compiler warnings |