Re: Query regarding selectDumpableExtension()

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: amul sul <sulamul(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Query regarding selectDumpableExtension()
Date: 2016-10-28 12:52:41
Message-ID: CA+Tgmob4r5XNLz-1Z1cMq4288v0MYk9yper_Pq_iWpbZ=10u2w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Oct 27, 2016 at 2:11 AM, amul sul <sulamul(at)gmail(dot)com> wrote:
> selectDumpableExtension() function skip
> s dump of
> built-in extensions in case of binary-upgrade only,
> why not in normal
> dump
> ?
> Can't we assume those will already be installed in the target database
> at restore
> ?

There's a comment in dumpExtension() that explains it.

/*
* In a regular dump, we use IF NOT EXISTS so that there isn't a
* problem if the extension already exists in the target database;
* this is essential for installed-by-default extensions such as
* plpgsql.
*
* In binary-upgrade mode, that doesn't work well, so instead we skip
* built-in extensions based on their OIDs; see
* selectDumpableExtension.
*/

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2016-10-28 12:54:54 Re: [BUG] pg_basebackup from disconnected standby fails
Previous Message Magnus Hagander 2016-10-28 12:49:51 Re: Streaming basebackups vs pg_stat_tmp