From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com> |
Cc: | Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Catalin Iacob <iacobcatalin(at)gmail(dot)com>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Peter van Hardenberg <pvh(at)pvh(dot)ca>, Peter Eisentraut <peter_e(at)gmx(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Patch: Implement failover on libpq connect level. |
Date: | 2016-12-02 15:24:30 |
Message-ID: | CA+Tgmoa_-V_CCL4+OrFcrGjxGL7GvtYJS7cEiDxirfbR7Em1jA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-jdbc |
On Thu, Dec 1, 2016 at 5:00 AM, Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com> wrote:
> On Wed, Nov 30, 2016 at 7:14 AM, Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com>
> wrote:
>> Thanks, send query resets the errorMessage. Will fix same.
>> PQsendQuery()->PQsendQueryStart()->resetPQExpBuffer(&conn->errorMessage);
>
> Please find the patch which fixes this bug. conn->errorMessage as per
> definition only stores current error message, a new member
> conn->savedMessage is introduced to save and restore error messages related
> to previous hosts which we failed to connect.
Couldn't this just be a variable in PQconnectPoll(), instead of adding
a new structure member?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2016-12-02 15:59:25 | Re: UNDO and in-place update |
Previous Message | Robert Haas | 2016-12-02 15:20:50 | Re: GIN non-intrusive vacuum of posting tree |
From | Date | Subject | |
---|---|---|---|
Next Message | Mithun Cy | 2016-12-05 04:00:21 | Re: Patch: Implement failover on libpq connect level. |
Previous Message | Vladimir Sitnikov | 2016-12-01 11:55:09 | Re: Database reset connection |