Re: pg_check_dir comments and implementation mismatch

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Marco Nenciarini <marco(dot)nenciarini(at)2ndquadrant(dot)it>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_check_dir comments and implementation mismatch
Date: 2015-01-29 17:37:25
Message-ID: CA+TgmoaP_v20z4S=bFZer9Og68yzACyQ3wcK5Pfbp4ztNNPVDw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jan 29, 2015 at 11:00 AM, Marco Nenciarini
<marco(dot)nenciarini(at)2ndquadrant(dot)it> wrote:
> reading pgcheckdir.c code I noticed that the function comment
> was outdated. The code now can return values from 0 to 4 while the
> comment explains only values 0,1,2.

This is not just a comment fix; you are clearly changing the behavior
of the function in some way.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2015-01-29 17:42:49 Re: pg_upgrade and rsync
Previous Message Bruce Momjian 2015-01-29 17:11:04 Re: pg_upgrade and rsync