Re: Only first XLogRecData is visible to rm_desc with WAL_DEBUG

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Only first XLogRecData is visible to rm_desc with WAL_DEBUG
Date: 2014-03-26 14:51:03
Message-ID: CA+TgmoaJ2BqjeQSvDqpAVtnVrWUbqSD6rF13KujndpnSy1j1ng@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 26, 2014 at 5:08 AM, Heikki Linnakangas
<hlinnakangas(at)vmware(dot)com> wrote:
> Oh, no, there's no need to do it while holding WALInsertLock. It's quite
> trivial, actually, see attached. So it's not difficult to fix this if we
> want to.

Well is there any reason not to just commit that patch? I mean, it
seems odd to rip this out if the fix is straightforward and already
written.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dang Minh Huong 2014-03-26 15:08:11 Duplicated row after promote in synchronous streaming replication
Previous Message Fabrízio de Royes Mello 2014-03-26 14:21:30 Re: [PATCH] Store Extension Options