Re: [HACKERS] [BUGS] BUG #14825: enum type: unsafe use?

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, "David E(dot) Wheeler" <david(at)justatheory(dot)com>, Christophe Pettus <christophe(dot)pettus(at)pgexperts(dot)com>, Postgres-Bugs <pgsql-bugs(at)postgresql(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] [BUGS] BUG #14825: enum type: unsafe use?
Date: 2018-01-12 03:19:02
Message-ID: CA+TgmoaJ-8QtU4qRdd73uOEkG1pQu1hdsrd++OmkkxRBYyR6ig@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Thu, Jan 11, 2018 at 6:01 PM, Thomas Munro
<thomas(dot)munro(at)enterprisedb(dot)com> wrote:
> [ the data isn't session lifetime ]
>
> So I agree with Tom's suggestion:
>
> On Wed, Oct 4, 2017 at 2:29 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Perhaps serialize the contents into an array in DSM, then rebuild a hash
>> table from that in the worker. Robert might have a better idea though.
>
> I'd happily volunteer to write or review a patch to do that. Is there
> a rebase of the stuff that got reverted, to build on?

Those seem like reasons not to use Session, but not necessarily
reasons not to have the leader directly build the dshash that the
workers access rather than building a separate hash table in every
worker.

Maybe having every worker build a separate hash table is a good idea
for some reason, but it's not clear to me that you've stated such a
reason.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Thomas Munro 2018-01-12 04:01:58 Re: [HACKERS] [BUGS] BUG #14825: enum type: unsafe use?
Previous Message Andres Freund 2018-01-11 23:05:10 Re: BUG #14932: SELECT DISTINCT val FROM table gets stuck in an infinite loop

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2018-01-12 03:30:38 Re: [Sender Address Forgery]Re: [Sender Address Forgery]Re: [HACKERS] path toward faster partition pruning
Previous Message Robert Haas 2018-01-12 03:15:34 Re: Parameters in user-defined aggregate final functions