Re: Why we don't have checksums on clog files

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Alex Ignatov <a(dot)ignatov(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Why we don't have checksums on clog files
Date: 2016-06-13 12:01:05
Message-ID: CA+TgmoaCsmKfB_Sv0QOMJ2wjPcY7U4N8y=sk=Y3ztxSpoCfJNg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Jun 12, 2016 at 10:54 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Tue, Jun 7, 2016 at 10:41 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>>> I think it will be better if users can have an option to checksum clog
>>> pages. However, I think that will need a change in page (CLOG-page) format
>>> which might not be a trivial work to accomplish.
>
>> Doesn't the pd_checksum field exist on SLRU pages also?
>
> Uh, no.
>
> (I don't think that's an inherent property of slru.c, but definitely
> clog.c packs the pages totally fully of xact status bits. See
> CLOG_XACTS_PER_PAGE.

Oh. Well, that makes it harder, then.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ants Aasma 2016-06-13 13:10:16 Re: WIP: Data at rest encryption
Previous Message Julien Rouhaud 2016-06-13 09:42:31 Re: Rename max_parallel_degree?