Re: pg_tablespace_location() error message

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_tablespace_location() error message
Date: 2012-04-11 00:54:57
Message-ID: CA+TgmoaA4Q-8zVx74kU9-mZ=d=oz1n50_XrXR8n+UGvaFBWT+g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Apr 10, 2012 at 7:57 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> If we expect this function to mainly be applied to pg_class.reltablespace,
> then it seems like it ought to understand that zero means "the database
> default" and substitute the database's default tablespace.  That might
> or might not be the same as the cluster default.
>
> Alternatively, we could expect pg_upgrade to understand that and make
> the substitution itself, but if the same would be needed by most uses of
> the function, maybe we should just do it here.

+1 for doing it in the function. I think that will improve
ease-of-use and give up nothing.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message 乔志强 2012-04-11 01:06:01 Re: [streaming replication] 9.1.3 streaming replication bug ?
Previous Message Peter Geoghegan 2012-04-11 00:53:06 Re: Patch: add timing of buffer I/O requests