| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, John Naylor <john(dot)naylor(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Delay locking partitions during INSERT and UPDATE |
| Date: | 2019-02-20 15:42:56 |
| Message-ID: | CA+TgmoZq7aiLR9tGB59wMzgFxTGXuY4d4RuLZXvoc4Pz7UUM4w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Feb 19, 2019 at 4:07 PM David Rowley
<david(dot)rowley(at)2ndquadrant(dot)com> wrote:
> I'd say that here we should only discuss what this patch is doing, ...
On that note, I spent some more time looking at what the patch is doing today.
/*
* We locked all the partitions in ExecSetupPartitionTupleRouting
* including the leaf partitions.
*/
- partrel = table_open(dispatch->partdesc->oids[partidx], NoLock);
+ partrel = table_open(dispatch->partdesc->oids[partidx], RowExclusiveLock);
It seems to me that the reason for this change is precisely that the
comment is now false, and therefore the comment needs to be updated.
Does that sound right?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-02-20 15:50:44 | Re: speeding up planning with partitions |
| Previous Message | Christoph Berg | 2019-02-20 15:37:19 | Re: list append syntax for postgresql.conf |