Re: [PATCH] Change missleading comment for tm_mon field of pg_tm structure

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Dmitry Fedin <dmitry(dot)fedin(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Change missleading comment for tm_mon field of pg_tm structure
Date: 2017-01-24 14:39:10
Message-ID: CA+TgmoZbfNQew5t0_qw3MFYsYs3oDq=O6aMCiUNbQKYnrCDFtQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jan 19, 2017 at 2:52 PM, Dmitry Fedin <dmitry(dot)fedin(at)gmail(dot)com> wrote:
> According to usages, tm_mon (month) field has origin 1, not 0. This is
> difference from C-library version of struct tm, which has origin 0 for
> real.

Hmm, thanks for noticing. Looks like it has been wrong for a really long time.

Your patch got garbled; it had two-space indents instead of tabs, so
it didn't apply. It's best to attach them rather than including them
inline.

Committed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Konstantin Knizhnik 2017-01-24 14:47:27 Deadlock in XLogInsert at AIX
Previous Message Nikhil Sontakke 2017-01-24 14:26:31 Re: Speedup twophase transactions